• 1 Post
  • 10 Comments
Joined 2 years ago
cake
Cake day: July 1st, 2023

help-circle





  • Oh, you get the benefit of explicit scanning?

    We get the beauty of every file that’s modified being scanned before the write “completes”. It’s an absolute joy starting a build and watching ~80% of the available compute be consumed by antivirus software.

    Or, you know, normal filesystem caching as part of your tool’s workflow.

    Or dependency installing and unpacking…

    Or anything actually that touches a lot of files.




  • I mean, that could be extreme, or really not that bad.

    Refactors have a way of generating a lot of changes. Half our job is code review, kind of have to get over it and go read some code.

    If someone put the effort in to write it, it’s your responsibility to put the effort in to read it and review it.

    If the style is difficult to read and non-standard for your repository or not. Conventional then your repository and your engineering team should be following set standards to ensure consistency.

    If you’re doing this then most PRS shouldn’t be that difficult to review.

    I say this, spending a decent part of my week reviewing something like 40+ PRs.