• ulterno@programming.dev
    link
    fedilink
    English
    arrow-up
    12
    ·
    5 days ago

    So I looked at the thing and it looked kinda reasonable.

    1. It was a bot and noone is making a scene.
    2. The bot was not telling that to the committer, but to the commenter, who is part of the company owning the repo
    3. The comment in question was, “Good to merge? Test suite passes locally?”, which might trip someone as “Test suite passes locally” seems like an affirmative, but the ‘?’ doesn’t say the same, so the reader would have to determine whether the commenter typo-ed a ‘?’ or actually meant to put a question, while using the wrong matching sentence form (which I know we are all guilty of, but tends to be fine while speaking, because our tone tells the listener)